prevent submission if password is not included

[jacklynhma]

PR is ready for review

Objective: Prevent the profile update form from submitting if the user forgets to add their password so they do not have to fill the form out again.

Old behavior:

• User updates their email
• User either clicks enter or clicks on "Update" button
• Page reloads and gets the below error message
• User needs to re-enter their email

New Behavior:

• User updates their email
• User either clicks enter or clicks on "Update" button
• The page focuses on the password field and user sees this:

• User types in passwords and DOES NOT need to re-enter email
• User clicks "Update" button 🥳

More context: This PR opened during the Ruby Conf Hack day. Thanks @martinemde for suggesting this fix :).

[jacklynhma]

Note to self: I need to write the test in the system folder

rubygems.org/test/system/multifactor_auths_test.rb

Line 147 in dd89efd

fullscreen_headless_chrome_driver

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.16%. Comparing base (a07d05c) to head (f79ad96).
Report is 15 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5250      +/-   ##
==========================================
- Coverage   96.85%   94.16%   -2.70%     
==========================================
  Files         456      456              
  Lines        9529     9607      +78     
==========================================
- Hits         9229     9046     -183     
- Misses        300      561     +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[martinemde]

Looks good once tests are passing. Thanks you for fixing this!

[martinemde]

This may not be readable by capybara because it's browser generated.

What if you click submit, comment about what's happening (browser halted submit because password is required), then filled the password and submitted again and check that the new value is saved.

[jacklynhma]

Done! I had to write this as a system test rather than an integration test since the system test runs the test on actual chrome.

[jacklynhma]

@martinemde Tests are passing, but looks like the build is failing is the code coverage 😅 .. but I wrote a test for the code change..

[martinemde]

Looks great! Don't worry about the project test coverage. We'll need to raise that overall across the project to get it to stop warning. It's not this commit's fault.

[martinemde]

Tested on staging and it works great. Should be available on production soon. Thanks again @jacklynhma and happy to work with you again at the conference.

[jacklynhma]

Thanks @martinemde ! Happy to work with you again too :).