Allow access to some sidebar controls for owners of fully yanked gems #5260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access to control of ownership, trusted publishers, etc is still important so that new versions of the gem can be pushed.
segiddins
approved these changes
Nov 20, 2024
|
I decided to remove the downloads count from the sidebar after I took this screenshot, so that won't be shown. I think including it for a gem that's fully yanked doesn't quite make sense (and could help people find targets for high download gems) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5260 +/- ##
=======================================
Coverage 96.81% 96.81%
=======================================
Files 456 456
Lines 9548 9548
=======================================
Hits 9244 9244
Misses 304 304 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
martinemde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access to control ownerships, trusted publishers, etc is still important when all versions have been yanked so that new versions of the gem can be pushed.
Adds a limited sidebar view to yanked gems that is mostly only visible to owners. The only exception is if adoption, which will show on the page for non-owners if currently active.