Increase coverage in policy tests

app/policies/api/application_policy.rb

@@ -7,10 +7,6 @@ def initialize(api_key, scope)
       @scope = scope
     end
 
-    def resolve
-      raise NotImplementedError, "You must define #resolve in #{self.class}"
-    end
-
     private
 
     attr_reader :api_key, :scope

app/policies/api/nil_class_policy.rb

@@ -6,6 +6,6 @@ def resolve
   end
 
   def destroy?
-    false
+    deny t(:forbidden)
   end
 end

app/policies/application_policy.rb

@@ -9,10 +9,6 @@ def initialize(user, scope)
       @scope = scope
     end
 
-    def resolve
-      raise NotImplementedError, "You must define #resolve in #{self.class}"
-    end
-
     private
 
     attr_reader :user, :scope
@@ -26,38 +22,6 @@ def initialize(user, record)
     @error = nil
   end
 
-  def index?
-    false
-  end
-
-  def show?
-    false
-  end
-
-  def create?
-    false
-  end
-
-  def new?
-    create?
-  end
-
-  def update?
-    false
-  end
-
-  def edit?
-    update?
-  end
-
-  def destroy?
-    false
-  end
-
-  def search?
-    index?
-  end
-
   private
 
   delegate :t, to: I18n

app/policies/rubygem_policy.rb

@@ -8,22 +8,10 @@ class Scope < ApplicationPolicy::Scope
   alias rubygem record
   delegate :organization, to: :rubygem
 
-  def show?
-    true
-  end
-
   def create?
     user.present?
   end
 
-  def update?
-    false
-  end
-
-  def destroy?
-    false
-  end
-
   def configure_oidc?
     rubygem_owned_by_with_role?(user, minimum_required_role: :owner, minimum_required_org_role: :admin)
   end

test/policies/api/nil_class_policy_test.rb

@@ -0,0 +1,21 @@
+require "test_helper"
+
+class Api::NilClassPolicyTest < ApiPolicyTestCase
+  def policy!(api_key)
+    Pundit.policy!(api_key, [:api, nil])
+  end
+
+  context "::Scope.resolve" do
+    should "raise" do
+      assert_raises Pundit::NotDefinedError do
+        Api::NilClassPolicy::Scope.new(nil, nil).resolve
+      end
+    end
+  end
+
+  context "#destroy?" do
+    should "not be authorized" do
+      refute_authorized policy!(nil), :destroy?, "Forbidden"
+    end
+  end
+end

test/policies/membership_policy_test.rb

@@ -96,26 +96,24 @@ def policy!(user, record = Membership)
     context "removing owner" do
       should "be authorized for org owners only" do
         membership = create(:membership, :owner, organization: @organization)
-        membership.role = :admin
 
-        assert_authorized policy!(@owner, membership), :update?
+        assert_authorized policy!(@owner, membership), :destroy?
 
-        refute_authorized policy!(@admin, membership), :update?
-        refute_authorized policy!(@maintainer, membership), :update?
-        refute_authorized policy!(@guest, membership), :update?
+        refute_authorized policy!(@admin, membership), :destroy?
+        refute_authorized policy!(@maintainer, membership), :destroy?
+        refute_authorized policy!(@guest, membership), :destroy?
       end
     end
 
     context "removing admin" do
       should "be authorized for org admins and owners" do
         membership = create(:membership, :admin, organization: @organization)
-        membership.role = :maintainer
 
-        assert_authorized policy!(@owner, membership), :update?
-        assert_authorized policy!(@admin, membership), :update?
+        assert_authorized policy!(@owner, membership), :destroy?
+        assert_authorized policy!(@admin, membership), :destroy?
 
-        refute_authorized policy!(@maintainer, membership), :update?
-        refute_authorized policy!(@guest, membership), :update?
+        refute_authorized policy!(@maintainer, membership), :destroy?
+        refute_authorized policy!(@guest, membership), :destroy?
       end
     end
   end

test/policies/rubygem_policy_test.rb

@@ -33,6 +33,14 @@ def org_policy!(user)
     Pundit.policy!(user, @org_rubygem)
   end
 
+  context "#create?" do
+    should "allow users" do
+      assert_authorized policy!(@owner), :create?
+      assert_authorized policy!(@user), :create?
+      refute_authorized policy!(nil), :create?
+    end
+  end
+
   context "#configure_oidc?" do
     should "only allow the owner" do
       assert_authorized policy!(@owner), :configure_oidc?