Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Japanese translation #5272

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Update Japanese translation #5272

wants to merge 15 commits into from

Conversation

gemmaro
Copy link
Contributor

@gemmaro gemmaro commented Nov 23, 2024

Hello RubyGems,

This updates Japanese translation (continuation of #4779).
Each commit adds changes corresponding to those made to the respective English/Japanese file (en.yml/ja.yml), as specified in the commit subject.

Thank you,
gemmaro.


TODOs to be ready for review.
  • Self-check the translation by looking at the way the messages are called.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.36%. Comparing base (94e09f7) to head (4eb4e49).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5272      +/-   ##
==========================================
- Coverage   97.13%   94.36%   -2.77%     
==========================================
  Files         457      457              
  Lines        9567     9626      +59     
==========================================
- Hits         9293     9084     -209     
- Misses        274      542     +268     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinemde
Copy link
Member

Thank you for all these updates. Do you feel this is ready for review or are there more changes you would like to make?

Should we have someone else check your work? My preference is for merging quickly and then applying fixes quickly but I would also appreciate a Japanese language review if possible.

@gemmaro
Copy link
Contributor Author

gemmaro commented Dec 14, 2024

Sorry for the delay. Now it is ready for review (I made some changes to the draft.)

Should we have someone else check your work? My preference is for merging quickly and then applying fixes quickly but I would also appreciate a Japanese language review if possible.

I agree with your approach of merging quickly and then applying fixes quickly.
I hope any corrections will be made later (I'd like to ping @okuramasafumi, and others are welcome to check as well!)

@gemmaro gemmaro marked this pull request as ready for review December 14, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants