Bump rails to 8.0.1

[dependabot]

Bumps rails-i18n and rails. These dependencies needed to be updated together.
Updates rails-i18n from 7.0.10 to 8.0.1

Changelog

Sourced from rails-i18n's changelog.

8.0.1 (2024-11-10)

• Update following locales:
  • English (en): Add missing key (password_too_long)
  • Portuguese (pt): Add missing keys (password_too_long, negative_format, and zb)
• Update Gemfile

8.0.0 (2024-11-10)

• Update to Rails 8.0.x
• Drop support for Ruby 3.0 and 3.1

Commits

• See full diff in compare view

Updates rails from 7.2.1.1 to 8.0.1

Release notes

Sourced from rails's releases.

8.0.0

Active Support

• Remove deprecated support to passing an array of strings to ActiveSupport::Deprecation#warn.

  Rafael Mendonça França

• Remove deprecated support to setting attr_internal_naming_format with a @ prefix.

  Rafael Mendonça França

• Remove deprecated ActiveSupport::ProxyObject.

  Rafael Mendonça França

• Don't execute i18n watcher on boot. It shouldn't catch any file changes initially, and unnecessarily slows down boot of applications with lots of translations.

  Gannon McGibbon, David Stosik

• Fix ActiveSupport::HashWithIndifferentAccess#stringify_keys to stringify all keys not just symbols.

  Previously:

  { 1 => 2 }.with_indifferent_access.stringify_keys[1] # => 2

  After this change:

  { 1 => 2 }.with_indifferent_access.stringify_keys["1"] # => 2

  This change can be seen as a bug fix, but since it behaved like this for a very long time, we're deciding to not backport the fix and to make the change in a major release.

  Jean Boussier

• Include options when instrumenting ActiveSupport::Cache::Store#delete and ActiveSupport::Cache::Store#delete_multi.

  Adam Renberg Tamm

• Print test names when running rails test -v for parallel tests.

  John Hawthorn, Abeid Ahmed

• Deprecate Benchmark.ms core extension.

  The benchmark gem will become bundled in Ruby 3.5

... (truncated)

Commits

• dd8f718 Preparing for 8.0.0 release
• f88e6ae Merge pull request #53550 from tysongach/devcontainer-links
• 43425c8 Bump deprecation message to 8.1
• 38bf52d Add yarn.lock to allowed dirty files
• 3de9afc Merge pull request #53546 from matthewd/dst_deprecation_fix
• ebcb66e Merge pull request #53542 from Uaitt/remove-redundant-period-in-security-guides
• 4f042a8 Merge pull request #53520 from Earlopain/fix-backtrace-env-gem-paths
• 74608e5 Merge pull request #53533 from Earlopain/no-docs-for-rackup
• 8ee2d3e Merge pull request #53504 from SleeplessByte/fix/anchor-scroll-mobile
• 473f2b2 Merge pull request #53515 from k-tsuchiya-jp/fix-53467
• Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request

Dependency Name	Ignore Conditions
rails	[> 7.0.8]

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Note: Dependabot was ignoring updates to this dependency, but since you've updated it yourself we've started tracking it for you again. 🤖

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[martinemde]

I manually spot checked a few pages to make sure dev is still working. The tests are otherwise much better than manual checking, so this is probably safe. We can update the framework defaults after this is merged.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.13%. Comparing base (94e09f7) to head (c906f18).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5279   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files         457      457           
  Lines        9567     9567           
=======================================
  Hits         9293     9293           
  Misses        274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[martinemde]

I set the framework default to 8.0. None of the changes look like they will affect us. I expect the tests to cover us (and if they don't, then we won't find it by enabling them one at a time).

[martinemde]

I have reverted load_defaults to 7.2 so that we introduce fewer changes (in particular, the changes rails core thought might affect upgrading). We can convert to rails 8.0 defaults after this merge is stable.

[martinemde]

I feel good about this. I mentioned elsewhere but I'll summarize here:

1. Our tests fail on rails 7.2 (master) with "7.2" framework defaults due to a test job order problem. (it impacts 2 tests in admin that rely on a job running in the middle of the test run)
2. They pass on rails 7.2 (master) with "7.1" defaults
3. They pass on rails 8.0 (this branch) with "7.2" and "8.0" defaults.

This implies to me that there is a bug in the test job runner (or a change in behavior) in rails 7.2 with default settings. It was seemingly fixed, for how we use them, in rails 8.0.

Therefore I don't think it makes sense to step to "7.2" framework defaults before going to rails 8.0 with "7.2" defaults because the work to fix the tests is ultimately unnecessary.

🚀

[martinemde]

Waiting for 8.0.1, but I'll leave this open since the upgrade will be about the same.

[martinemde]

Updated to 8.0.1 🎉

[simi]

What about this?

DEPRECATION WARNING: `to_time` will always preserve the full timezone rather than offset of the receiver in Rails 8.1. To opt in to the new behavior, set `config.active_support.to_time_preserves_timezone = :zone`. (called from <top (required)> at /home/runner/work/rubygems.org/rubygems.org/config/environment.rb:5)

[martinemde]

@simi that's in the framework defaults. I'm fine with enabling them now but there was hesitation with jumping to them right away. Maybe one deploy with 7.2 and then switch to 8.0?

[simi]

@simi that's in the framework defaults. I'm fine with enabling them now but there was hesitation with jumping to them right away. Maybe one deploy with 7.2 and then switch to 8.0?

I prefer no deprecation warnings. Those are super annoying for developers (and mostly for new contributors).

[martinemde]

I prefer no deprecation warnings. Those are super annoying for developers (and mostly for new contributors).

I managed to find a place to put the line to remove the deprecation warning. Leaving it in the new_framework_defaults file doesn't successfully suppress the warning.