Add semgrep workflow #5293
Open
Add semgrep workflow #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5293 +/- ##
=======================================
Coverage 96.88% 96.88%
=======================================
Files 457 457
Lines 9576 9576
=======================================
Hits 9278 9278
Misses 298 298 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Samuel Giddins <[email protected]>
segiddins
force-pushed
the
segiddins/add-semgrep-workflow
branch
from
c0e74e1 to
76150a0
Compare
martinemde
approved these changes
Dec 1, 2024
| jobs: | ||
| semgrep: | ||
| name: semgrep/ci | ||
| runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Nit: pretty old ubuntu. LTS ends in < 6 months.
simi
reviewed
Dec 2, 2024
| SEMGREP_APP_TOKEN: ${{ secrets.SEMGREP_APP_TOKEN }} | ||
| container: | ||
| image: semgrep/semgrep | ||
| if: (github.actor != 'dependabot[bot]') |
There was a problem hiding this comment.
Is it skipped, since dependabot doesn't do code-changes?
There was a problem hiding this comment.
Btw. isn't the name just dependabot or Dependabot currently?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samuel Giddins [email protected]