Update and move onboarding controller tests to test/functional #5307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5307 +/- ##
==========================================
- Coverage 97.14% 97.14% -0.01%
==========================================
Files 457 457
Lines 9564 9561 -3
==========================================
- Hits 9291 9288 -3
Misses 273 273 ☔ View full report in Codecov by Sentry. |
These tests fit more with the functional paradigm since they are named after a controller and test one action at a time.
martinemde
force-pushed
the
martinemde/organization-tests
branch
from
22ba159 to
b63b64e
Compare
martinemde
changed the title
martinemde
force-pushed
the
martinemde/organization-tests
branch
from
b63b64e to
faa796d
Compare
|
Since it's been 2 days and this is just test changes (except moving the call to layout) I'm going to merge this. I don't want to make this diff significantly more complex by building on top of these test only changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests fit more with the functional paradigm since they are named after a controller and test one action at a time.
Updated to follow functional testing pattern.