Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run staging as RAILS_ENV=production #5308

Closed
wants to merge 1 commit into from

Conversation

martinemde
Copy link
Member

Avoid accidental differences between staging and production. Describe all differences in ENV.

Avoid accidental differences between staging and production.
Describe all differences in ENV.
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.07%. Comparing base (a786900) to head (ee0a313).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5308      +/-   ##
==========================================
- Coverage   97.14%   97.07%   -0.08%     
==========================================
  Files         457      457              
  Lines        9564     9564              
==========================================
- Hits         9291     9284       -7     
- Misses        273      280       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simi
Copy link
Member

simi commented Dec 4, 2024

We should run staging as separate env with RAILS_ENV=staging, but copy production config (as done in staging.rb) and don't rely on Rails.env.production?, but on feature config.

@martinemde
Copy link
Member Author

Closing in favor of the less scary #5309, for now.

@martinemde martinemde closed this Dec 4, 2024
@martinemde martinemde deleted the martinemde/remove-rails-env-staging branch December 4, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants