-
-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ruby to 3.3.6 #5318
Update Ruby to 3.3.6 #5318
Conversation
Thanks for upgrade @Uaitt! Once CI passes I can merge and deploy. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5318 +/- ##
==========================================
- Coverage 97.14% 94.37% -2.77%
==========================================
Files 457 457
Lines 9561 9620 +59
==========================================
- Hits 9288 9079 -209
- Misses 273 541 +268 ☔ View full report in Codecov by Sentry. |
@simi and @martinemde I have rebased this branch so that it's up to date with |
Any idea why the coverage is getting lower with this commit? 😅 |
@Uaitt not really, I think worth to explore. I can take a look. |
When I looked it seems like the Avo tests were not being counted. All of the coverage changes were due to avo related files. I'm going to go ahead and merge this now. I'm don't think coverage actually changed because of this. |
@martinemde But per my understanding Avo tests were triggered in this PR also. Those strange coverage drops often reveal codepath changes. 🤔 |
@simi I was hoping to see if the coverage dropped on master as well so we could rule out Avo tests being skipped when submitted by an person outside the org. |
As the title says :)