Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby to 3.3.6 #5318

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Update Ruby to 3.3.6 #5318

merged 1 commit into from
Dec 9, 2024

Conversation

Uaitt
Copy link
Contributor

@Uaitt Uaitt commented Dec 5, 2024

As the title says :)

@simi
Copy link
Member

simi commented Dec 5, 2024

Thanks for upgrade @Uaitt! Once CI passes I can merge and deploy.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.37%. Comparing base (21de964) to head (f40cdb4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5318      +/-   ##
==========================================
- Coverage   97.14%   94.37%   -2.77%     
==========================================
  Files         457      457              
  Lines        9561     9620      +59     
==========================================
- Hits         9288     9079     -209     
- Misses        273      541     +268     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Uaitt
Copy link
Contributor Author

Uaitt commented Dec 6, 2024

@simi and @martinemde I have rebased this branch so that it's up to date with master and I have changed the commit hash of the ruby/setup-ruby action

@Uaitt
Copy link
Contributor Author

Uaitt commented Dec 9, 2024

Any idea why the coverage is getting lower with this commit? 😅

@simi
Copy link
Member

simi commented Dec 9, 2024

@Uaitt not really, I think worth to explore. I can take a look.

@martinemde
Copy link
Member

When I looked it seems like the Avo tests were not being counted. All of the coverage changes were due to avo related files.

I'm going to go ahead and merge this now. I'm don't think coverage actually changed because of this.

@martinemde martinemde merged commit ff030e9 into rubygems:master Dec 9, 2024
18 of 19 checks passed
@simi
Copy link
Member

simi commented Dec 9, 2024

@martinemde But per my understanding Avo tests were triggered in this PR also. Those strange coverage drops often reveal codepath changes. 🤔

@martinemde
Copy link
Member

@simi I was hoping to see if the coverage dropped on master as well so we could rule out Avo tests being skipped when submitted by an person outside the org.

@simi
Copy link
Member

simi commented Dec 9, 2024

I thought all tests are running for all PRs. But maybe I'm wrong, since AFAIK secrets are not provided to community PRs. 🤔

image

@Uaitt Uaitt deleted the ruby-3.3.6 branch December 10, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants