Convert params.permit to params.expect
#5357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use params[:id] for params in path
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5357 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 458 458
Lines 9584 9584
=======================================
Hits 9310 9310
Misses 274 274 ☔ View full report in Codecov by Sentry. |
martinemde
commented
Dec 22, 2024
| statements_attributes: [[ | ||
| :effect, | ||
| principal: :oidc, | ||
| conditions_attributes: [%i[operator claim value]] |
There was a problem hiding this comment.
Hey @segiddins this line doesn't fail any tests either way, but it looks like this is how the code works. I guess we don't pass conditions in a test?
martinemde
commented
Dec 22, 2024
| @@ -39,7 +39,7 @@ def in_audited_transaction(auditable:, admin_github_user:, action:, fields:, arg | |||
| changes = merge_changes!(changes, record.attributes.slice("id").transform_values { [_1, _1] }) if changes.key?("id") | |||
| changes = merge_changes!(changes, record.attributes.compact.transform_values { [_1, nil] }) if record.destroyed? | |||
|
|
|||
| [key, { changes:, unchanged: record.attributes.except(*changes.keys) }] | |||
There was a problem hiding this comment.
Rubocop side-effect. Not related to this change but necessary to keep lint passing (while also improving how expect syntax is used)
segiddins
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay! 😀