Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to verify patching without executing daemon. #363

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

labkode
Copy link
Member

@labkode labkode commented Jan 21, 2025

Fixes #362

Example:

docker buildx build --build-arg TAG=36.0.0 --file ./daemons/Dockerfile  daemons/ --tag myrucio

Applies patches if any and starts daemon

docker run -e RUCIO_DAEMON=hermes myrucio
$ docker run -e RUCIO_DAEMON=hermes myrucio
=================== installing davix with openssl 3.1 ============================
rucio.cfg not found. will generate one.
INFO:root:Merged 74 configuration values from /tmp/rucio.config.default.cfg
INFO:root:Merged 0 configuration values from ENV
INFO:root:Writing /opt/rucio/etc/rucio.cfg
Patches not found
starting sendmail for hermes
....
....

Only applies patches:

$ docker run -e RUCIO_DAEMON_ONLY_CHECK_PATCHES=1 myrucio
=================== installing davix with openssl 3.1 ============================
rucio.cfg not found. will generate one.
INFO:root:Merged 74 configuration values from /tmp/rucio.config.default.cfg
INFO:root:Merged 0 configuration values from ENV
INFO:root:Writing /opt/rucio/etc/rucio.cfg
Patches not found
$ echo $?
0

@bari12
Copy link
Member

bari12 commented Jan 28, 2025

@labkode did you discuss this with @ericvaandering yet? I will change the PR to draft in the meanwhile.

@bari12 bari12 marked this pull request as draft January 28, 2025 15:05
@labkode
Copy link
Member Author

labkode commented Jan 28, 2025

@bari12 yes all good. This PR does not have any impact in any deployment as it only adds an optional step.
However, after discussing with @ericvaandering I will add a few more improvements he suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to verify patches without running daemons
3 participants