-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize expired dids to use prom pusher #143
Open
voetberg
wants to merge
1
commit into
rucio:master
Choose a base branch
from
voetberg:129-update-expired-dids
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,59 +1,58 @@ | ||
#!/usr/bin/env python | ||
# Copyright European Organization for Nuclear Research (CERN) 2013 | ||
#!/usr/bin/env python3 | ||
# Copyright European Organization for Nuclear Research (CERN) since 2012 | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# You may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# Authors: | ||
# - Vincent Garonne, <[email protected]>, 2013 | ||
# - Thomas Beermann, <[email protected]>, 2019 | ||
# - Eric Vaandering <[email protected]>, 2020-2021 | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
""" | ||
Probe to check the backlog of expired dids. | ||
""" | ||
from __future__ import print_function | ||
|
||
import sys | ||
import traceback | ||
from datetime import datetime | ||
|
||
from prometheus_client import CollectorRegistry, Gauge, push_to_gateway | ||
from rucio.common.config import config_get | ||
from sqlalchemy import and_, func, null, select | ||
|
||
from rucio.db.sqla import models | ||
from rucio.db.sqla.session import get_session | ||
from rucio.db.sqla.util import get_count | ||
|
||
from utils.common import probe_metrics | ||
from utils.common import PrometheusPusher | ||
|
||
# Exit statuses | ||
OK, WARNING, CRITICAL, UNKNOWN = 0, 1, 2, 3 | ||
|
||
PROM_SERVERS = config_get('monitor', 'prometheus_servers', raise_exception=False, default='') | ||
if PROM_SERVERS != '': | ||
PROM_SERVERS = PROM_SERVERS.split(',') | ||
|
||
if __name__ == "__main__": | ||
try: | ||
registry = CollectorRegistry() | ||
session = get_session() | ||
query = session.query(models.DataIdentifier.scope).filter(models.DataIdentifier.expired_at.isnot(None), | ||
models.DataIdentifier.expired_at < datetime.utcnow()) | ||
result = get_count(query) | ||
# Possible check against a threshold. If result > max_value then sys.exit(CRITICAL) | ||
probe_metrics.gauge(name='undertaker.expired_dids').set(result) | ||
Gauge('undertaker_expired_dids', '', registry=registry).set(result) | ||
|
||
if len(PROM_SERVERS): | ||
for server in PROM_SERVERS: | ||
try: | ||
push_to_gateway(server.strip(), job='check_expired_dids', registry=registry) | ||
except: | ||
continue | ||
|
||
print(result) | ||
except: | ||
statement = select( | ||
func.count() | ||
).select_from( | ||
models.DataIdentifier | ||
).where( | ||
and_( | ||
models.DataIdentifier.expired_at != null(), | ||
models.DataIdentifier.expired_at < datetime.utcnow() | ||
) | ||
) | ||
expired_dids = session.execute(statement).scalar_one() | ||
print(expired_dids) | ||
|
||
with PrometheusPusher() as manager: | ||
(manager.gauge( | ||
"expired_dids.total", | ||
documentation="All expired dids") | ||
.set(expired_dids)) | ||
except Exception: | ||
print(traceback.format_exc()) | ||
sys.exit(UNKNOWN) | ||
sys.exit(OK) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires further review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the "requires further review?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the other two PRs: (1) it silently changes the metric name to (2) one that is arguably inferior.