Skip to content

Commit

Permalink
Revert "feat: added drop traits in track call feature for mixpanel (#…
Browse files Browse the repository at this point in the history
…1870)"

This reverts commit 474cde5.
  • Loading branch information
manish339k authored Jan 22, 2025
1 parent 41be203 commit 4f65355
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 51 deletions.
3 changes: 1 addition & 2 deletions src/configurations/destinations/mp/db-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,7 @@
"useUserDefinedPageEventName",
"userDefinedPageEventTemplate",
"useUserDefinedScreenEventName",
"userDefinedScreenEventTemplate",
"dropTraitsInTrackEvent"
"userDefinedScreenEventTemplate"
],
"android": [
"consentManagement",
Expand Down
4 changes: 0 additions & 4 deletions src/configurations/destinations/mp/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@
"type": "boolean",
"default": false
},
"dropTraitsInTrackEvent": {
"type": "boolean",
"default": false
},
"people": {
"type": "boolean",
"default": false
Expand Down
22 changes: 0 additions & 22 deletions src/configurations/destinations/mp/ui-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -162,28 +162,6 @@
}
]
},
{
"title": "Track Settings",
"note": "Set how you want to send your track calls to Mixpanel",
"icon": "file",
"fields": [
{
"type": "checkbox",
"label": "Drop Traits",
"configKey": "dropTraitsInTrackEvent",
"note": "Drop traits from event property in track call",
"default": false,
"preRequisites": {
"fields": [
{
"configKey": "connectionModes.cloud",
"value": true
}
]
}
}
]
},
{
"title": "Mixpanel Configuration Settings",
"fields": [
Expand Down
23 changes: 0 additions & 23 deletions test/data/validation/destinations/mp.json
Original file line number Diff line number Diff line change
Expand Up @@ -741,28 +741,5 @@
"ketchConsentPurposes.web must be array",
"ketchConsentPurposes.unity.0 must be object"
]
},
{
"config": {
"token": "dummy-token",
"dataResidency": "us",
"people": false,
"setAllTraitsByDefault": false,
"consolidatedPageCalls": true,
"trackCategorizedPages": false,
"trackNamedPages": false,
"crossSubdomainCookie": false,
"persistence": "localStorage",
"secureCookie": false,
"eventFilteringOption": "disable",
"useNativeSDK": {
"web": false
},
"strictMode": false,
"ignoreDnt": true,
"dropTraitsInTrackEvent": "inValid"
},
"result": false,
"err": ["dropTraitsInTrackEvent must be boolean"]
}
]

0 comments on commit 4f65355

Please sign in to comment.