fix: added more test, disable cdkv2

rudderlabs · Sep 9, 2024 · 64249a6 · 64249a6
1 parent 4c2de79
commit 64249a6
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 1 deletion.
diff --git a/src/configurations/destinations/intercom_v2/db-config.json b/src/configurations/destinations/intercom_v2/db-config.json
@@ -2,7 +2,6 @@
   "name": "INTERCOM_V2",
   "displayName": "Intercom V2",
   "config": {
-    "cdkV2Enabled": true,
     "supportsVisualMapper": true,
     "transformAtV1": "router",
     "saveDestinationResponse": true,

diff --git a/test/data/validation/destinations/intercom_v2.json b/test/data/validation/destinations/intercom_v2.json
@@ -1,4 +1,49 @@
 [
+  {
+    "config": {
+      "apiVersion": "v2",
+      "apiServer": "eu",
+      "connectionMode": {
+        "ios": "cloud"
+      },
+      "oneTrustCookieCategories": [
+        {
+          "oneTrustCookieCategory": ""
+        }
+      ]
+    },
+    "result": true
+  },
+  {
+    "config": {
+      "apiVersion": "dummyVersion",
+      "connectionMode": {
+        "ios": "cloud"
+      },
+      "oneTrustCookieCategories": [
+        {
+          "oneTrustCookieCategory": ""
+        }
+      ]
+    },
+    "result": false,
+    "err": ["apiVersion must be equal to one of the allowed values"]
+  },
+  {
+    "config": {
+      "apiServer": "dummyServer",
+      "connectionMode": {
+        "ios": "cloud"
+      },
+      "oneTrustCookieCategories": [
+        {
+          "oneTrustCookieCategory": ""
+        }
+      ]
+    },
+    "result": false,
+    "err": ["apiServer must be equal to one of the allowed values"]
+  },
   {
     "testTitle": "With valid multiple consent management providers config",
     "config": {