Skip to content

Commit

Permalink
fix: resolving comments
Browse files Browse the repository at this point in the history
  • Loading branch information
manish339k committed Oct 24, 2024
1 parent 9d49dab commit 9986758
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 101 deletions.
21 changes: 8 additions & 13 deletions src/configurations/destinations/intercom_v2/db-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"role": "intercom",
"rudderScopes": ["delivery"]
},
"includeKeys": ["oneTrustCookieCategories", "consentManagement", "ketchConsentPurposes"],
"excludeKeys": [],
"supportedSourceTypes": [
"android",
Expand All @@ -21,8 +20,7 @@
"cloud",
"reactnative",
"flutter",
"cordova",
"shopify"
"cordova"
],
"supportedMessageTypes": {
"cloud": ["identify", "track", "group"]
Expand All @@ -36,27 +34,23 @@
"reactnative": ["cloud"],
"flutter": ["cloud"],
"cordova": ["cloud"],
"shopify": ["cloud"],
"cloud": ["cloud"]
},
"destConfig": {
"defaultConfig": ["rudderAccountId", "apiServer", "sendAnonymousId"],
"android": [
"useNativeSDK",
"connectionMode",
"consentManagement",
"oneTrustCookieCategories",
"ketchConsentPurposes"
],
"ios": [
"useNativeSDK",
"connectionMode",
"consentManagement",
"oneTrustCookieCategories",
"ketchConsentPurposes"
],
"web": [
"useNativeSDK",
"connectionMode",
"consentManagement",
"oneTrustCookieCategories",
Expand Down Expand Up @@ -97,14 +91,15 @@
"consentManagement",
"oneTrustCookieCategories",
"ketchConsentPurposes"
],
"shopify": [
"connectionMode",
"consentManagement",
"oneTrustCookieCategories",
"ketchConsentPurposes"
]
},
"secretKeys": []
},
"options": {
"isBeta": true,
"hidden": {
"featureFlagName": "AMP_intercom_v2",
"featureFlagValue": false
}
}
}
88 changes: 0 additions & 88 deletions src/configurations/destinations/intercom_v2/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -116,32 +116,6 @@
}
}
}
},
"shopify": {
"type": "array",
"items": {
"type": "object",
"properties": {
"oneTrustCookieCategory": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
}
}
}
}
}
},
"useNativeSDK": {
"type": "object",
"properties": {
"android": {
"type": "boolean"
},
"ios": {
"type": "boolean"
},
"web": {
"type": "boolean"
}
}
},
Expand Down Expand Up @@ -561,52 +535,6 @@
}
]
}
},
"shopify": {
"type": "array",
"items": {
"type": "object",
"properties": {
"provider": {
"type": "string",
"enum": ["custom", "ketch", "oneTrust"],
"default": "oneTrust"
},
"consents": {
"type": "array",
"items": {
"type": "object",
"properties": {
"consent": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
}
}
}
}
},
"allOf": [
{
"if": {
"properties": {
"provider": {
"const": "custom"
}
},
"required": ["provider"]
},
"then": {
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
}
}
]
}
}
}
},
Expand Down Expand Up @@ -720,18 +648,6 @@
}
}
}
},
"shopify": {
"type": "array",
"items": {
"type": "object",
"properties": {
"purpose": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
}
}
}
}
}
},
Expand Down Expand Up @@ -770,10 +686,6 @@
"type": "string",
"enum": ["cloud"]
},
"shopify": {
"type": "string",
"enum": ["cloud"]
},
"cloud": {
"type": "string",
"enum": ["cloud"]
Expand Down

0 comments on commit 9986758

Please sign in to comment.