Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: standard formatting #1198

Merged
merged 12 commits into from
Feb 12, 2024
Merged

chore: standard formatting #1198

merged 12 commits into from
Feb 12, 2024

Conversation

sanpj2292
Copy link
Contributor

What are the changes introduced in this PR?

  • Added verify workflow
    • Python formatting check is included
    • Javascript formatting & eslint checks are also included
  • Commitlint workflow has also been added
  • Included a script for formatting all Python files in the repository(format.sh)
  • Added the formatter script to pre-commit hook

What is the related Linear task?

Resolves INT-1500

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new checks got introduced or modified in test suites. Please explain the changes.

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • I have executed schemaGenerator tests and updated schema if needed

  • Are sensitive fields marked as secret in definition config?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Signed-off-by: Sai Sankeerth <[email protected]>
Copy link

linear bot commented Feb 8, 2024

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6edc55b) 0.00% compared to head (c57a36a) 100.00%.

Additional details and impacted files
@@              Coverage Diff               @@
##           develop     #1198        +/-   ##
==============================================
+ Coverage         0   100.00%   +100.00%     
==============================================
  Files            0         2         +2     
  Lines            0        53        +53     
  Branches         0         7         +7     
==============================================
+ Hits             0        53        +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sai Sankeerth added 2 commits February 8, 2024 17:13
.github/workflows/verify.yml Outdated Show resolved Hide resolved
.github/workflows/verify.yml Outdated Show resolved Hide resolved
.github/workflows/verify.yml Outdated Show resolved Hide resolved
.github/workflows/verify.yml Outdated Show resolved Hide resolved
scripts/format.sh Outdated Show resolved Hide resolved
.husky/pre-commit Outdated Show resolved Hide resolved
@sanpj2292 sanpj2292 requested a review from saikumarrs February 8, 2024 14:36
saikumarrs
saikumarrs previously approved these changes Feb 8, 2024
@sanpj2292 sanpj2292 requested a review from saikumarrs February 9, 2024 07:13
Sai Sankeerth added 2 commits February 9, 2024 12:55
@krishna2020 krishna2020 merged commit 009c8da into develop Feb 12, 2024
8 checks passed
@krishna2020 krishna2020 deleted the chore.standard-format branch February 12, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants