Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard new destination ninetailed #1211

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented Feb 13, 2024

What are the changes introduced in this PR?

Onboard new integration ninetailed destination
Write a brief explainer on your code changes.
It supports identify, track and page calls and requires OrganisationId and environment to generate endpoint and send data and thats what we are taking from the

What is the related Linear task?

Resolves INT-295
Screenshot 2024-02-13 at 5 11 32 PM

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new checks got introduced or modified in test suites. Please explain the changes.

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • I have executed schemaGenerator tests and updated schema if needed

  • Are sensitive fields marked as secret in definition config?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Copy link

linear bot commented Feb 13, 2024

INT-295 Event stream destination: Ninetailed Integration

Reviewers: shrouti gauravudia

Onboard new Integration Ninetailed as cloud mode and web-sdk destination

References of the requirement (Slack/Notion/PRD doc)

https://rudderlabs.slack.com/archives/D03L204JX8C/p1691437826072369




  • The Slack link for the respective thread is attached.
  • Docs card attached.
  • GitHub PR is attached to the task.
  • Release label attached to the task.
  • The project associated with the task is linked, if any.
  • Document the monitoring steps here

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2bfdb1d) to head (dfa3f88).
Report is 58 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1211   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           53        53           
  Branches         7         7           
=========================================
  Hits            53        53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shrouti1507
shrouti1507 previously approved these changes Feb 26, 2024
src/configurations/destinations/ninetailed/db-config.json Outdated Show resolved Hide resolved
src/configurations/destinations/ninetailed/schema.json Outdated Show resolved Hide resolved
src/configurations/destinations/ninetailed/schema.json Outdated Show resolved Hide resolved
src/configurations/destinations/ninetailed/ui-config.json Outdated Show resolved Hide resolved
src/configurations/destinations/ninetailed/ui-config.json Outdated Show resolved Hide resolved
src/configurations/destinations/ninetailed/ui-config.json Outdated Show resolved Hide resolved
src/configurations/destinations/ninetailed/ui-config.json Outdated Show resolved Hide resolved
src/configurations/destinations/ninetailed/ui-config.json Outdated Show resolved Hide resolved
@anantjain45823 anantjain45823 merged commit ef2045f into develop Feb 29, 2024
7 checks passed
@anantjain45823 anantjain45823 deleted the feat.newDestNinetailed branch February 29, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants