feat: move warehouses to new UI config #1230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cisse21
force-pushed
the
feat.warehouseNewFormBuilder
branch
2 times, most recently
from
473bc4e to
dfd7d44
Compare
cisse21
force-pushed
the
feat.warehouseNewFormBuilder
branch
from
dfd7d44 to
8bb90db
Compare
cisse21
force-pushed
the
feat.warehouseNewFormBuilder
branch
10 times, most recently
from
44c22d2 to
cc64a65
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1230 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 53 53
Branches 7 7
=========================================
Hits 53 53 ☔ View full report in Codecov by Sentry. |
cisse21
force-pushed
the
feat.warehouseNewFormBuilder
branch
from
cc64a65 to
1973290
Compare
cisse21
force-pushed
the
feat.warehouseNewFormBuilder
branch
from
1973290 to
5071c49
Compare
cisse21
force-pushed
the
feat.warehouseNewFormBuilder
branch
3 times, most recently
from
429ac16 to
7ae604a
Compare
cisse21
force-pushed
the
feat.warehouseNewFormBuilder
branch
2 times, most recently
from
7944fa1 to
9bf293e
Compare
cisse21
requested review from
krishna2020,
desusai7,
1abhishekpandey and
bardisg
as code owners
cisse21
force-pushed
the
feat.warehouseNewFormBuilder
branch
4 times, most recently
from
a5efb70 to
27f3e9a
Compare
cisse21
force-pushed
the
feat.warehouseNewFormBuilder
branch
14 times, most recently
from
d873252 to
878cb48
Compare
cisse21
force-pushed
the
feat.warehouseNewFormBuilder
branch
from
878cb48 to
d26294a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
Moving Old Form Builder to New Form Builder for All the warehouse destinations
What is the related Linear task?
Fixes PIPE-296
Fixes PIPE-293
Fixes PIPE-398
Fixes PIPE-658
Fixes PIPE-354
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new checks got introduced or modified in test suites. Please explain the changes.
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
I have executed schemaGenerator tests and updated schema if needed
Are sensitive fields marked as secret in definition config?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.