Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make accessToken required only for cloud mode #1233

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

sandeepdsvs
Copy link
Contributor

@sandeepdsvs sandeepdsvs commented Feb 22, 2024

What are the changes introduced in this PR?

For Facebook Pixel destination, made business access token required only when cloud mode connection exists

What is the related Linear task?

Resolves INT-1633

Please explain the objectives of your changes below

Screenshot 2024-02-22 at 2 10 45 PM Screenshot 2024-02-22 at 2 11 19 PM Screenshot 2024-02-22 at 6 16 05 PM Screenshot 2024-02-22 at 6 16 39 PM

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new checks got introduced or modified in test suites. Please explain the changes.

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • I have executed schemaGenerator tests and updated schema if needed

  • Are sensitive fields marked as secret in definition config?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Copy link

linear bot commented Feb 22, 2024

INT-1633 Facebook Pixels: Incorrect field conditions for different modes

When creating a Facebook Pixel destination I am not able to click “Continue” unless I have added a Business Access Token, even though this is only required for cloud mode and I have selected device mode for the connection mode.


Notion document: https://www.notion.so/When-creating-a-Facebook-Pixel-destination-I-am-not-able-to-click-Continue-unless-I-have-added-a-B-b89b2ee8083745f3baff0e4cb2129c27
Slack Link: https://rudderlabs.slack.com/archives/C02A3UPEWMU/p1708456294630209
Channel: ask-control-plane
Created By: Emil Sadek
thread_id=<1708456294.630209>
channel_id=

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbd3b7f) 100.00% compared to head (6cc8cb4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1233   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           53        53           
  Branches         7         7           
=========================================
  Hits            53        53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandeepdsvs sandeepdsvs merged commit 32e1d10 into develop Feb 23, 2024
8 checks passed
@sandeepdsvs sandeepdsvs deleted the fix.fb_pixel_access_token branch February 23, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants