fix: preload events not processed with detached load call #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
size-limit report 📦
|
saikumarrs
merged commit 6b0f66f
into
hotfix/preload-events-buffer
6 of 7 checks passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hotfix/preload-events-buffer #1953 +/- ##
================================================================
- Coverage 58.30% 58.29% -0.01%
================================================================
Files 485 485
Lines 16614 16613 -1
Branches 3333 3348 +15
================================================================
- Hits 9686 9685 -1
+ Misses 5713 5703 -10
- Partials 1215 1225 +10 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The auto-tracking page life cycle feature added recently introduced a bug in which the preloaded events were discarded when the
loadcall was not part of it.I've fixed the issue by getting the preloaded events from the globals object instead of
window.rudderanalyticsobject in theloadAPI.Additional updates:
Linear task (optional)
https://linear.app/rudderstack/issue/SDK-2715/fix-e2e-test-suite-failures
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security