fix: adding minor test cases

rudderlabs · Dec 11, 2024 · 2170f58 · 2170f58
1 parent db5884d
commit 2170f58
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/router/batchrouter/asyncdestinationmanager/clevertap_segment/upload.go b/router/batchrouter/asyncdestinationmanager/clevertap_segment/upload.go
@@ -111,7 +111,7 @@ func (u *ClevertapBulkUploader) createCSVFile(inputDataFilePath string) (*Action
 	defer inputFile.Close()
 
 	scanner := bufio.NewScanner(inputFile)
-	scanner.Buffer(nil, 50000*1024) // Adjust the buffer size if necessary
+	scanner.Buffer(nil, 50000*1024) //  maximum size of a single line that the scanner can read. Adjust the buffer size if necessary
 
 	for scanner.Scan() {
 		line := scanner.Text()

diff --git a/router/batchrouter/asyncdestinationmanager/clevertap_segment/utils_test.go b/router/batchrouter/asyncdestinationmanager/clevertap_segment/utils_test.go
@@ -43,7 +43,8 @@ func TestGetBulkApi(t *testing.T) {
 	assert.NotNil(t, endpoints)
 	assert.NotEmpty(t, endpoints.BulkApi)
 	assert.NotEmpty(t, endpoints.NotifyApi)
-	// TODO: Validate endpoints.BulkApi and endpoints.NotifyApi
+	assert.Equal(t, "https://in1.api.clevertap.com/get_custom_list_segment_url", endpoints.BulkApi)
+	assert.Equal(t, "https://in1.api.clevertap.com/upload_custom_list_segment_completed", endpoints.NotifyApi)
 }
 
 func TestConvertToConnectionConfig(t *testing.T) {