-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace schema struct with interface to enable flexible implementation #5426
Conversation
warehouse/router/upload_test.go
Outdated
conf: conf, | ||
db: sqlmiddleware.New(pgResource.DB), | ||
} | ||
rs := redshift.New(config.New(), logger.NOP, stats.NOP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a manager in here, instead of directly accessing redshift package?
rs := redshift.New(config.New(), logger.NOP, stats.NOP) | |
whManager, err := manager.New(warehouseutils.POSTGRES, conf, logger.NOP, statsStore) | |
require.NoError(t, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced redshift with manager. I had used redshift because that is how other tests were written
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we would need to fix other tests as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5426 +/- ##
==========================================
- Coverage 74.81% 74.78% -0.03%
==========================================
Files 440 440
Lines 61639 61668 +29
==========================================
+ Hits 46115 46120 +5
- Misses 12987 13006 +19
- Partials 2537 2542 +5 ☔ View full report in Codecov by Sentry. |
Description
Refactoring
Schema
->schema
Linear Ticket
resolves WAR-150
Security