Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: transformer 404 error logs #5437

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

vinayteki95
Copy link
Contributor

@vinayteki95 vinayteki95 commented Jan 15, 2025

Description

This commit aims to allow logging of 404 errors in the processor while communicating with transformer to trigger log based alerts (loki)

Transformer can respond with 404 errors if the destination is not available in the transformer image but the config-backend has the destination.
This can only happend when some outdated transformer image is used in the deployment. In order to catch such errors and immediately alert (throw loki-log based triggers) the team to make a fix, we aim to log 404 errors and add alerts for those errors.
The below ticket is attached with corresponding alert PR in devops as well.

Linear Ticket

Resolves INT-3031
https://linear.app/rudderstack/issue/INT-3031/revisit-transformer-and-rudder-server-api-contracts-and-throw-alerts

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@vinayteki95 vinayteki95 changed the title Chore.transformer 404 error logs chore: transformer 404 error logs Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.85%. Comparing base (cd4a7e1) to head (0427544).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5437      +/-   ##
==========================================
+ Coverage   74.82%   74.85%   +0.03%     
==========================================
  Files         440      440              
  Lines       61668    61668              
==========================================
+ Hits        46141    46164      +23     
+ Misses      12991    12960      -31     
- Partials     2536     2544       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinayteki95 vinayteki95 marked this pull request as ready for review January 16, 2025 07:39
@vinayteki95 vinayteki95 requested review from lvrach and mihir20 January 16, 2025 07:40
@utsabc
Copy link
Member

utsabc commented Jan 16, 2025

Can you add some more context in the description?

@vinayteki95
Copy link
Contributor Author

@utsabc Updated the description with more details. Good catch, this PR is very vague without the context.

@vinayteki95 vinayteki95 merged commit 886008a into master Jan 16, 2025
58 checks passed
@vinayteki95 vinayteki95 deleted the chore.transformer-404-error-logs branch January 16, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants