-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: transformer 404 error logs #5437
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5437 +/- ##
==========================================
+ Coverage 74.82% 74.85% +0.03%
==========================================
Files 440 440
Lines 61668 61668
==========================================
+ Hits 46141 46164 +23
+ Misses 12991 12960 -31
- Partials 2536 2544 +8 ☔ View full report in Codecov by Sentry. |
Can you add some more context in the description? |
@utsabc Updated the description with more details. Good catch, this PR is very vague without the context. |
Description
This commit aims to allow logging of 404 errors in the processor while communicating with transformer to trigger log based alerts (loki)
Transformer can respond with 404 errors if the destination is not available in the transformer image but the config-backend has the destination.
This can only happend when some outdated transformer image is used in the deployment. In order to catch such errors and immediately alert (throw loki-log based triggers) the team to make a fix, we aim to log 404 errors and add alerts for those errors.
The below ticket is attached with corresponding alert PR in devops as well.
Linear Ticket
Resolves INT-3031
https://linear.app/rudderstack/issue/INT-3031/revisit-transformer-and-rudder-server-api-contracts-and-throw-alerts
Security