Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement object storage delete validations for warehouse destinations #5456

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

shekhar-rudder
Copy link
Member

@shekhar-rudder shekhar-rudder commented Jan 27, 2025

Description

With #5428 being merged, this update enhances the validations API for creating/updating destinations by adding a step to verify if RudderStack has object storage delete permissions.

Implementation Details

  • This new step is included only if the deletion config is set to true.
  • It will be the final part of checking the "Object storage" permissions
  • Attempt to delete the uploaded file. If the deletion step fails, an error message will be propagated to the web app, informing the user of the issue.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.82%. Comparing base (71efda1) to head (9af52a3).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
warehouse/validations/validate.go 47.05% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5456      +/-   ##
==========================================
- Coverage   74.84%   74.82%   -0.03%     
==========================================
  Files         440      440              
  Lines       61425    61442      +17     
==========================================
- Hits        45974    45972       -2     
- Misses      12916    12940      +24     
+ Partials     2535     2530       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

warehouse/validations/validate_test.go Outdated Show resolved Hide resolved
@shekhar-rudder shekhar-rudder merged commit 06e99fa into master Jan 29, 2025
58 checks passed
@shekhar-rudder shekhar-rudder deleted the war-213-delete-validations branch January 29, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants