-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use axios-mock-adapter for mocking axios requests #2647
Merged
sanpj2292
merged 10 commits into
feat.add-comp-test-axios-mocking
from
feat.use-axios-mock-adapter
Sep 27, 2023
Merged
feat: use axios-mock-adapter for mocking axios requests #2647
sanpj2292
merged 10 commits into
feat.add-comp-test-axios-mocking
from
feat.use-axios-mock-adapter
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- migrate several destinations already in component test suite to this - migrate all user-deletion destinations to compnent test suite - remove global axios mock formation automatically
sanpj2292
requested review from
shrouti1507 and
ujjwal-ab
and removed request for
a team
September 24, 2023 20:46
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat.add-comp-test-axios-mocking #2647 +/- ##
====================================================================
+ Coverage 86.89% 86.95% +0.05%
====================================================================
Files 613 634 +21
Lines 28216 28302 +86
Branches 6708 6711 +3
====================================================================
+ Hits 24519 24609 +90
+ Misses 3363 3359 -4
Partials 334 334
☔ View full report in Codecov by Sentry. |
Signed-off-by: Sai Sankeerth <[email protected]>
koladilip
reviewed
Sep 25, 2023
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
koladilip
reviewed
Sep 26, 2023
koladilip
approved these changes
Sep 27, 2023
Signed-off-by: Sai Sankeerth <[email protected]>
koladilip
approved these changes
Sep 27, 2023
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Resolves INT-371
We are making use of axios-mock-adapter library to mock axios requests
Type of change
Related issues
Checklists
Development
Code review