Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor javascript generator #13

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

akashrpo
Copy link

Thanks for taking the time to contribute to RudderTyper!

It is highly appreciated that you take the time to help improve RudderTyper.
We appreciate it if you would take the time to document your Pull Request.

Sadly, if we don't receive enough information, or the Pull Request doesn't
align well with our roadmap, we might respectfully thank you for your time, and close the issue.

Respect earns Respect 👏

Please respect our Code of Conduct, in short:

  • Using welcoming and inclusive language.
  • Being respectful of differing viewpoints and experiences.
  • Gracefully accepting constructive criticism.
  • Focusing on what is best for the community.
  • Showing empathy towards other community members.

@akashrpo akashrpo requested a review from Jayachand February 13, 2024 18:04
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (961b872) 88.82% compared to head (3ca8c08) 88.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files           3        3           
  Lines         170      170           
  Branches       58       58           
=======================================
  Hits          151      151           
  Misses         17       17           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akashrpo akashrpo requested a review from desusai7 February 14, 2024 03:49
@akashrpo akashrpo force-pushed the feat/refactor-js-generator branch 2 times, most recently from 4396a9f to c8b8d32 Compare February 16, 2024 10:44
@akashrpo akashrpo force-pushed the feat/refactor-js-generator branch from c8b8d32 to 3ca8c08 Compare February 16, 2024 11:00
@desusai7 desusai7 assigned snarkychef and akashrpo and unassigned snarkychef Feb 16, 2024
@akashrpo akashrpo merged commit 716a87e into master Feb 19, 2024
3 checks passed
@akashrpo akashrpo deleted the feat/refactor-js-generator branch February 19, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants