Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make RudderTyperUtils.java compilable with -werror #91

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

TWiStErRob
Copy link

Description 📝

The generated code has problems with Java's built-in compiler checks when used with -Werror:

warning: [rawtypes] found raw type: List
warning: [unchecked] unchecked call to add(E) as a member of the raw type List
error: warnings found and -Werror specified
1 error
4 warnings
warnings found and -Werror specified

Fixing the rawtypes problems fixes the others.

@contributor-support
Copy link

Thank you @TWiStErRob for contributing this PR.
Please sign the Contributor License Agreement (CLA) before merging.

@akashrpo akashrpo changed the title Make RudderTyperUtils.java compilable with -Werror fix: make RudderTyperUtils.java compilable with -werror Dec 12, 2024
@akashrpo akashrpo merged commit 4fe0627 into rudderlabs:develop Dec 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants