Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propensity model failing for pkg project #526

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: propensity model failing for pkg project #526

wants to merge 2 commits into from

Conversation

shubhammehra4
Copy link
Collaborator

@shubhammehra4 shubhammehra4 commented Dec 9, 2024 •
edited
Loading

Description of the change

Fix model_ref to use level root

wht PR

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Linear Ticket

Resolves PRML-974

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@shubhammehra4 shubhammehra4 added the v0.7.0 This label signifies PRs to be merged before 0.7.0 release label Dec 9, 2024
@shubhammehra4 shubhammehra4 added the DO NOT MERGE Approved but need to check more label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker2411 joker2411 Awaiting requested review from joker2411

@dpatchigolla dpatchigolla Awaiting requested review from dpatchigolla

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
DO NOT MERGE Approved but need to check more v0.7.0 This label signifies PRs to be merged before 0.7.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shubhammehra4