chore: respect catalog restriction in ListColumns #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
changed the title
atzoum
requested review from
RanjeetMishra,
kuldeep0020,
nishantsharma,
AchuthaSourabhC,
vyeshwanth,
Vikas26021999 and
ruchiramoitra
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 87.81% 88.33% +0.52%
==========================================
Files 55 59 +4
Lines 2002 2143 +141
==========================================
+ Hits 1758 1893 +135
- Misses 170 173 +3
- Partials 74 77 +3 ☔ View full report in Codecov by Sentry. |
atzoum
changed the title
atzoum
force-pushed
the
chore.catalogInListColumns
branch
2 times, most recently
from
4a64f32 to
8f00f56
Compare
atzoum
force-pushed
the
chore.catalogInListColumns
branch
from
8f00f56 to
57c416a
Compare
atzoum
commented
Mar 21, 2024
| @@ -25,8 +25,5 @@ func (c *Config) Parse(configJson json.RawMessage) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| if c.Catalog == "" { | |||
| c.Catalog = "hive_metastore" // default catalog | |||
There was a problem hiding this comment.
Note: rudder-sources now sets this as a default value, the library assumes no default value
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a catalog is passed as an argument in
ListColumns, it should be included as a condition it in the sql statement.Bonus: introducing
CurrentCatalogmethod to get the current catalog.Security