-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better loss system for broadcast_loss #126
Conversation
991e53f
to
a285d36
Compare
c33fb30
to
c01df8d
Compare
c01df8d
to
8d4184c
Compare
…dcy, cy and fused losses
8d4184c
to
15fae9b
Compare
In which situation would compute_loss return none ? Wouldn't we want an error in this case ? |
The rationale is that a domain module can choose to never have one of the loss (e.g. to not participate to translations).
Those were not added in this PR and have been part of shimmer for some times already, but it was not used by the broadcast loss. But basically yes, it's useful in case translation and demi cycles not use the same exact loss function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK makes sense :)
I added documented the change and explicited what I just wrote. I agree, it wasn't clear originally. |
if compute_loss returns None, it's skipped + Broadcast loss uses tr, dcy, cy and fused losses