remove broadcast related work #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took out all the "critical" private stuff that had made it to shimmer from my work
Mainly I took out the broadcast loss, the associated batch_[] functions, the selection classes that featured attention, and the tests that used these classes. I also took out the globalworkspace that has fusion, and the GWLossesFusion.
Normally this shouldn't break anything for anyone who isn't using fusion.
I also took various imports out of init.py in shimmer and modules
and lastly took out the saving test in save_model.py
and changed the migrations file in a way that shouldn't cause any issue