Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dataset.py corrected order of valid and train arguments in DomainDataModule #83

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Update dataset.py corrected order of valid and train arguments in DomainDataModule #83

merged 2 commits into from
Sep 19, 2024

Conversation

NicolasKuske
Copy link
Collaborator

see last pull request

@NicolasKuske NicolasKuske changed the title Update dataset.py swapped valid and train arguments in datadomain Update dataset.py corrected order of valid and train arguments in DataDomainModule May 19, 2024
@NicolasKuske NicolasKuske changed the title Update dataset.py corrected order of valid and train arguments in DataDomainModule Update dataset.py corrected order of valid and train arguments in DomainDataModule May 19, 2024
bdvllrs
bdvllrs reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@bdvllrs bdvllrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked to #82, I shall accept this when the other one is complete. (maybe next time put all related changes in the same PR :-))

@bdvllrs bdvllrs merged commit 854ea4b into main Sep 19, 2024
1 check passed
@bdvllrs bdvllrs deleted the NicolasKuske-patch-7 branch September 19, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdvllrs bdvllrs bdvllrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicolasKuske @bdvllrs