Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GWInterfaceBase, GWInterface, and co. #9

Merged
merged 8 commits into from
Mar 6, 2024
Merged

Conversation

bdvllrs
Copy link
Collaborator

@bdvllrs bdvllrs commented Mar 6, 2024

GWInterfaceBase, GWInterface, and co, were useless abstractions of encoders and decoders.

Now, GWModule additionaly takes the domain_mods as parameter.
Moreover, instead of requiring gw_intefaces it now needs to mapping: gw_encoders and gw_decoders which are torch.nn.Modules that encode or decode the unimodal representation to and from the GW representation.

See updated docs/shimmer_basics.md and examples to see how to update existing code.

@bdvllrs bdvllrs merged commit c739207 into main Mar 6, 2024
1 check passed
@bdvllrs bdvllrs deleted the remove_gw_interface branch March 6, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant