adding status updater / device plugin for kwok nodes #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enoodle
force-pushed
the
erez/kwok-fake-node-updater-RUN-19999
branch
from
234abe6 to
da9a600
Compare
enoodle
force-pushed
the
erez/kwok-fake-node-updater-RUN-19999
branch
2 times, most recently
from
c249f8d to
8bacea1
Compare
enoodle
force-pushed
the
erez/kwok-fake-node-updater-RUN-19999
branch
from
8bacea1 to
62b10f0
Compare
enoodle
force-pushed
the
erez/kwok-fake-node-updater-RUN-19999
branch
3 times, most recently
from
1e69249 to
d81ff8d
Compare
enoodle
force-pushed
the
erez/kwok-fake-node-updater-RUN-19999
branch
from
d81ff8d to
4e370cb
Compare
gshaibi
approved these changes
Aug 20, 2024
| c := &ConfigMapController{ | ||
| kubeClient: kubeClient, | ||
| cmInformer: informerFactory.Core().V1().ConfigMaps().Informer(), | ||
| nodeLister: informerFactory.Core().V1().Nodes().Lister(), |
There was a problem hiding this comment.
Do we still need the node lister?
|
|
||
| type ConfigMapController struct { | ||
| kubeClient kubernetes.Interface | ||
| cmInformer cache.SharedIndexInformer |
There was a problem hiding this comment.
Do we need to keep it in the struct?
There was a problem hiding this comment.
No, I will remove this
| informerFactory informers.SharedInformerFactory | ||
| handler cmhandler.Interface | ||
|
|
||
| clusterTopology *topology.ClusterTopology |
There was a problem hiding this comment.
Do we need to keep it in the struct?
There was a problem hiding this comment.
No, I will remove this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.