Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUN-23692 Helm chart versioning in CD #98

Merged
merged 1 commit into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,4 @@ $(GINKGO):
test-all: $(GINKGO)
$(GINKGO) -r --procs=1 --output-dir=/tmp/artifacts/test-results/service-tests --compilers=1 --randomize-all --randomize-suites --fail-on-pending --keep-going --timeout=5m --race --trace --json-report=report.json
.PHONY: test-all

4 changes: 2 additions & 2 deletions deploy/fake-gpu-operator/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: CHART_VERSION
version: 0.0.1 # Replaced during CD

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: CHART_VERSION
appVersion: 0.0.1 # Replaced during CD
3 changes: 1 addition & 2 deletions script/uploadChart.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,10 @@ upload() {
echo "[ERROR] Exiting because unable to copy index locally. Not safe to proceed."
exit 1
fi
sed -i "s/"CHART_VERSION"/$CHART_VERSION/g" Chart.yaml
helm repo add ingress-nginx "https://kubernetes.github.io/ingress-nginx"
helm repo update
helm dep update .
helm package . -n runai --destination "$sync_dir"
helm package . -n runai --destination "$sync_dir" --version "$CHART_VERSION" --app-version "$CHART_VERSION"
if helm repo index --url "$REPO_URL" --merge "$index_dir/index.yaml" "$sync_dir"; then
# Move updated index.yaml to sync folder so we don't push the old one again
mv -f "$sync_dir/index.yaml" "$index_dir/index.yaml"
Expand Down
Loading