Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch dask from run_bash_over_ssh to run_bash. #1589

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Switch dask from run_bash_over_ssh to run_bash. #1589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions runhouse/resources/hardware/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2081,7 +2081,7 @@ def connect_dask(
)
else:
scheduler_options = ""
self.run_bash_over_ssh(
self.run_bash(
f"nohup dask scheduler --port {port} {scheduler_options} > dask_scheduler.out 2>&1 &",
node=self.head_ip,
stream_logs=True,
Expand All @@ -2104,7 +2104,7 @@ def connect_dask(
if node == self.head_ip
else remote_scheduler_address
)
self.run_bash_over_ssh(
self.run_bash(
f"nohup dask worker {scheduler} --host {self.internal_ips[idx]} {worker_options_str} > dask_worker.out 2>&1 &",
node=node,
)
Expand All @@ -2114,9 +2114,9 @@ def connect_dask(
return client

def kill_dask(self):
self.run_bash_over_ssh("pkill -f 'dask scheduler'", node=self.head_ip)
self.run_bash("pkill -f 'dask scheduler'", node=self.head_ip)
for node in self.ips:
self.run_bash_over_ssh("pkill -f 'dask worker'", node=node)
self.run_bash("pkill -f 'dask worker'", node=node)

def remove_conda_env(
self,
Expand Down
Loading