refactor

run-llama · Mar 15, 2024 · 27db0ae · 27db0ae
1 parent 653af4c
commit 27db0ae
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 15 deletions.
diff --git a/helpers/env-variables.ts b/helpers/env-variables.ts
@@ -77,20 +77,22 @@ const getVectorDBEnvs = (vectorDb: TemplateVectorDB) => {
           name: "MILVUS_ADDRESS",
           description:
             "The address of the Milvus server. Eg: http://localhost:19530",
+          value: "http://localhost:19530",
         },
         {
-          name: "MILVUS_USER",
+          name: "MILVUS_COLLECTION",
+          description:
+            "The name of the Milvus collection to store the vectors.",
+          value: "llamacollection",
+        },
+        {
+          name: "MILVUS_USERNAME",
           description: "The username to access the Milvus server.",
         },
         {
           name: "MILVUS_PASSWORD",
           description: "The password to access the Milvus server.",
         },
-        {
-          name: "MILVUS_COLLECTION",
-          description:
-            "The name of the Milvus collection to store the vectors. Default is 'llamacollection' if not specified.",
-        },
       ];
     default:
       return [];

diff --git a/helpers/typescript.ts b/helpers/typescript.ts
@@ -240,13 +240,6 @@ export const installTSTemplate = async ({
     };
   }
 
-  if (vectorDb === "milvus") {
-    packageJson.dependencies = {
-      ...packageJson.dependencies,
-      "@zilliz/milvus2-sdk-node": "^2.3.5",
-    };
-  }
-
   if (observability === "opentelemetry") {
     packageJson.dependencies = {
       ...packageJson.dependencies,

diff --git a/templates/components/vectordbs/typescript/milvus/generate.mjs b/templates/components/vectordbs/typescript/milvus/generate.mjs
@@ -25,7 +25,6 @@ async function loadAndIndex() {
   // Connect to Milvus
   const milvusClient = getMilvusClient();
   const vectorStore = new MilvusVectorStore({ milvusClient });
-  await vectorStore.connect();
 
   // now create an index from all the Documents and store them in Milvus
   const storageContext = await storageContextFromDefaults({ vectorStore });

diff --git a/templates/components/vectordbs/typescript/milvus/index.ts b/templates/components/vectordbs/typescript/milvus/index.ts
@@ -21,7 +21,6 @@ async function getDataSource(llm: LLM) {
   });
   const milvusClient = getMilvusClient();
   const store = new MilvusVectorStore({ milvusClient });
-  await store.connect();
 
   return await VectorStoreIndex.fromVectorStore(store, serviceContext);
 }