Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: react 19 stable #476

Merged
merged 5 commits into from
Dec 27, 2024
Merged

bump: react 19 stable #476

merged 5 commits into from
Dec 27, 2024

Conversation

thucpn
Copy link
Collaborator

@thucpn thucpn commented Dec 27, 2024

Next.js 15.1 supports for React 19 officially
https://nextjs.org/blog/next-15-1

Summary by CodeRabbit

  • New Features

    • Enhanced flexibility in the WeatherCard component by allowing a broader range of React elements for weather icons.
  • Chores

    • Updated various dependencies to their latest stable versions, including next, react, and eslint-config-next.
    • Changed the package manager from pnpm to npm for project setup.
    • Adjusted dependency version specifications to allow for minor updates in several packages.

Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: 3ea33a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

coderabbitai bot commented Dec 27, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request involves modifications to a Next.js component's type definition and updates to several dependency versions in the project's package.json files. The type change broadens the accepted types for the icon property in the weatherCodeDisplayMap from JSX.Element to React.ReactNode. Additionally, multiple packages, including next, react, and their type definitions, have been upgraded to their latest stable versions, reflecting a shift towards more flexible dependency management.

Changes

File Change Summary
templates/types/streaming/nextjs/app/components/ui/chat/tools/weather-card.tsx Updated icon property type from JSX.Element to React.ReactNode in weatherCodeDisplayMap
templates/types/streaming/nextjs/package.json Upgraded dependency versions:
- next: ^15.0.3^15.1.3
- react: 19.0.0-rc^19.0.0
- react-dom: 19.0.0-rc^19.0.0
- @types/react: ^18.2.42^19.0.2
- @types/react-dom: ^18.2.17^19.0.2
- eslint-config-next: ^15.0.3^15.1.3
templates/types/streaming/express/package.json Updated dependency versions:
- ai: 4.0.3^4.0.3
- pdf2json: 3.0.5^3.0.5
- @e2b/code-interpreter: 1.0.4^1.0.4
- tsup: 8.1.0^8.1.0
.changeset/smart-bears-confess.md New entry added for patch "create-llama," updating React to stable version 19.
e2e/utils.ts Changed package manager argument from "--use-pnpm" to "--use-npm" in runCreateLlama function.

Possibly related PRs

Suggested reviewers

  • marcusschiesser

Poem

🐰 In code we hop, with joy we play,
Icons now dance in a broader way!
React's new version, bright and clear,
Upgrades abound, let’s give a cheer!
With npm we run, our paths align,
Hopping forward, all will be fine! 🚀


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e389c4 and 3ab66b0.

📒 Files selected for processing (3)
  • .changeset/smart-bears-confess.md (1 hunks)
  • templates/types/streaming/express/package.json (2 hunks)
  • templates/types/streaming/nextjs/package.json (3 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0f9161 and 5e389c4.

📒 Files selected for processing (1)
  • e2e/utils.ts (1 hunks)
🔇 Additional comments (1)
e2e/utils.ts (1)

91-91: Consider adjusting dependency installation timeout for npm

The switch to npm might affect dependency installation times. The current timeout is set to 1 minute:

await waitForProcess(appProcess, 1000 * 60); // wait 1 min for dependencies to be resolved

Consider testing if this timeout is sufficient for npm, as it might have different performance characteristics compared to pnpm.

Let's check if there are any existing timeout configurations or related issues:

Also applies to: 144-146

✅ Verification successful

Timeout configuration is sufficient for npm dependency installation

The current timeout of 1 minute for dependency installation is part of a broader test configuration that includes:

  • A global test timeout of 5 minutes (timeout: 1000 * 60 * 5) in the Playwright config
  • A specific 1-minute timeout for dependency resolution (waitForProcess(appProcess, 1000 * 60))

This configuration should be sufficient for npm as:

  1. The 1-minute timeout is specifically for initial dependency resolution
  2. The broader 5-minute test timeout provides a safety net for the entire test execution
  3. The timeout values are consistent with typical CI/CD environments
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for timeout configurations
echo "Searching for timeout configurations..."
rg "timeout|waitForProcess" -A 3

# Search for related issues
echo "Checking for related issues..."
gh issue list --search "timeout npm dependencies"

Length of output: 19929

e2e/utils.ts Show resolved Hide resolved
@marcusschiesser marcusschiesser merged commit 5450096 into main Dec 27, 2024
46 checks passed
@marcusschiesser marcusschiesser deleted the bump/react-19-stable branch December 27, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants