Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Llama 3 and Phi3 (via Ollama) #53

Merged
merged 12 commits into from
Apr 24, 2024
Merged

Conversation

marcusschiesser
Copy link
Collaborator

@marcusschiesser marcusschiesser commented Apr 19, 2024

Summary by CodeRabbit

  • New Features

    • Introduced functionality for selecting and interacting with models from Ollama and OpenAI.
    • Updated template instructions for configuring OPENAI_API_KEY.
    • Enhanced chat components for consistent multimodal interactions.
  • Refactor

    • Streamlined backend environment variable generation.
    • Consolidated model configuration into a single ModelConfig type.
  • Bug Fixes

    • Improved initialization logic in settings files to support multiple model providers.
  • Chores

    • Removed outdated dependencies related to Llama models.

Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: 075dc2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-llama Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

coderabbitai bot commented Apr 19, 2024

Warning

Rate Limit Exceeded

@marcusschiesser has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 43 minutes and 34 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between a1a3d48 and 075dc2e.

Walkthrough

The recent updates enhance flexibility and provider support in the project. Changes introduce a ModelConfig type for streamlined model configuration, support for OpenAI and Ollama providers, and updates to environmental setup functions. Dependency adjustments and new template functionalities reflect these integration efforts.

Changes

Files Changes Summary
helpers/env-variables.ts Refactored for ModelConfig support and optional vectorDb parameter.
helpers/providers/ollama.ts, .../openai.ts Added model interaction functionality for Ollama and OpenAI.
helpers/python.ts Updated to handle ModelConfig in dependencies, removing useLlamaParse.
helpers/types.ts Introduced ModelConfig type, updated InstallTemplateArgs.
templates/types/streaming/.../README-template.md, .../pyproject.toml Updated instructions and dependencies based on provider changes.
templates/types/streaming/.../chat-section.tsx, .../settings.ts Updated for multi-model support and initialization based on MODEL_PROVIDER.

🐇✨
In the code's garden, changes bloom,
New paths unfold under the moon.
With Ollama's grace and OpenAI's might,
Our project grows into the night.
Cheers to codes that weave and stitch,
A tapestry rich, without a glitch! 🌟🌙


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

helpers/types.ts Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (2)
templates/types/streaming/express/src/controllers/engine/settings.ts (1)

27-38: Consider adding error handling for parsing EMBEDDING_DIM to ensure it's a valid integer.

templates/types/streaming/nextjs/app/api/chat/engine/settings.ts (1)

27-38: Consider adding error handling for parsing EMBEDDING_DIM to ensure it's a valid integer.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link
Collaborator

@leehuwuj leehuwuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature!

helpers/providers/openai.ts Outdated Show resolved Hide resolved
@marcusschiesser marcusschiesser changed the title Adding support for Llama 3 Adding support for Llama 3 and Phi3 (via Ollama) Apr 24, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

"create-llama": minor
---

Add Llama3 and Phi3 support using Ollama
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the model names for consistency.

- Add Llama3 and Phi3 support using Ollama
+ Add Llama 3 and Phi 3 support using Ollama

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
Add Llama3 and Phi3 support using Ollama
Add Llama 3 and Phi 3 support using Ollama

@marcusschiesser marcusschiesser merged commit f1c3e8d into main Apr 24, 2024
5 checks passed
@marcusschiesser marcusschiesser deleted the ms/add-llama3 branch April 24, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants