-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Llama 3 and Phi3 (via Ollama) #53
Conversation
🦋 Changeset detectedLatest commit: 075dc2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Warning Rate Limit Exceeded@marcusschiesser has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 43 minutes and 34 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates enhance flexibility and provider support in the project. Changes introduce a Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
a0e8fe8
to
bb8faea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
templates/types/streaming/express/src/controllers/engine/settings.ts (1)
27-38
: Consider adding error handling for parsingEMBEDDING_DIM
to ensure it's a valid integer.templates/types/streaming/nextjs/app/api/chat/engine/settings.ts (1)
27-38
: Consider adding error handling for parsingEMBEDDING_DIM
to ensure it's a valid integer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feature!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
"create-llama": minor | ||
--- | ||
|
||
Add Llama3 and Phi3 support using Ollama |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the model names for consistency.
- Add Llama3 and Phi3 support using Ollama
+ Add Llama 3 and Phi 3 support using Ollama
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Add Llama3 and Phi3 support using Ollama | |
Add Llama 3 and Phi 3 support using Ollama |
Summary by CodeRabbit
New Features
OPENAI_API_KEY
.Refactor
ModelConfig
type.Bug Fixes
Chores