Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make check-lint host to correctly install golangci-lint #2292

Closed
wants to merge 1 commit into from
Closed

Fix make check-lint host to correctly install golangci-lint #2292

wants to merge 1 commit into from

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jun 4, 2022 •
edited
Loading

what

  • Fix make check-lint host

The error returned from the current make check-lint command

curl: (6) Could not resolve host: install.goreleaser.com

why

  • Correctly install golangci-lint to resolve the failed linter checks

references

commands

make check-lint

@nitrocode nitrocode requested a review from a team as a code owner June 4, 2022 00:21
@nitrocode nitrocode force-pushed the fix-check-lint-host branch from f23fea2 to f3d0940 Compare June 4, 2022 00:29
jamengual
jamengual approved these changes Jun 4, 2022
View reviewed changes
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution

@jamengual
Copy link
Contributor

fixed here #2284 closing

@jamengual jamengual closed this Jun 4, 2022
@nitrocode nitrocode deleted the fix-check-lint-host branch June 4, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @jamengual