Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(install): Change wording of button to cancel index synchronization. #1567

Closed
Closed
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a9e5223
feat(install): Replaces index dialog prompt with sidebar buttons
castaway Jan 23, 2024
ad2e8b7
feat(index): Expand index sidebar dialog to cancel download
castaway Jan 31, 2024
a523891
test(search): Ensure search tests have known state before running
castaway Mar 4, 2024
09713f0
style(install): Adjust introductory search index prompt.
gtandersen Mar 9, 2024
da7a055
style(install): Improve formatting of buttons.
gtandersen Mar 9, 2024
3c39c03
Merge branch 'master' into geir/1509_index_sync_modal_adjustment
gtandersen Apr 1, 2024
15e3051
style(install): Adjust indexing prompt for mobile screens.
gtandersen Apr 1, 2024
d7bccd0
test(install): Update test.
gtandersen Apr 2, 2024
8aeeee3
feat(install): Replaces index dialog prompt with sidebar buttons
castaway Jan 23, 2024
60895d9
feat(index): Expand index sidebar dialog to cancel download
castaway Jan 31, 2024
699c2c0
test(search): Ensure search tests have known state before running
castaway Mar 4, 2024
3cd9bde
style(install): Adjust introductory search index prompt.
gtandersen Mar 9, 2024
4318dde
style(install): Improve formatting of buttons.
gtandersen Mar 9, 2024
68d64b6
Merge branch 'castaway/1509_index_sync_modal' into castaway/1509_inde…
castaway Apr 3, 2024
0989d38
Merge pull request #6 from gtandersen/castaway/1509_index_sync_modal
castaway Apr 3, 2024
4cc3c8b
style(install): Improve formatting for mobile phones.
gtandersen Apr 16, 2024
0b4be05
fix(index): Re-prompt local index download on each device
castaway Apr 17, 2024
5b4a3df
style(install): Change wording of button to cancel index synchronizat…
gtandersen Apr 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style(install): Improve formatting of buttons.
gtandersen committed Mar 9, 2024
commit da7a055d8442ed714da3a1e3109770e0cccd566e
2 changes: 1 addition & 1 deletion src/app/app.component.html
Original file line number Diff line number Diff line change
@@ -181,7 +181,7 @@ <h3 class="noMessageSelectedNotification">No Message Selected</h3>
<ng-container *ngIf="!hasChildRouterOutlet">
<div id="offerLocalIndex" *ngIf="offerInitialLocalIndex; else searchBar">
<p>
Runbox 7 can synchronize with your browser to give you an optimal webmail experience. The data can be deleted at any time using the buttons beneath the folder list.
Runbox 7 will synchronize with your device to give you an optimal webmail experience. The data can be deleted at any time using the buttons beneath the folder list.
</p>
<mat-list>
<mat-list-item>
4 changes: 4 additions & 0 deletions src/styles.scss
Original file line number Diff line number Diff line change
@@ -925,6 +925,10 @@ app-saved-searches .mat-list-base[dense] .mat-list-item {
white-space: normal;
line-height: 1em;

mat-list-item {
flex-grow: 1;
}

button {
margin-right: 10px;
}

Unchanged files with check annotations Beta

</p>
</table>
<div *ngIf="receipt.status == 1 && receipt.method === 'offline'">

Check warning on line 57 in src/app/account-app/account-receipt.component.html

GitHub Actions / Run lint tests

Expected `===` but received `==`
<h3>
Please follow the instructions for your selected payment method below.
</h3>
close_to_quota = [];
close_percentage = 90;
ngOnInit() {

Check warning on line 244 in src/app/account-app/account-renewals.component.ts

GitHub Actions / Run lint tests

Lifecycle interface 'OnInit' should be implemented for method 'ngOnInit'. (https://angular.io/styleguide#style-09-01)
this.close_to_quota = this.check_close_quota();
}
<ng-container matColumnDef="expansionIndicator">
<th mat-header-cell *matHeaderCellDef> </th>
<td mat-cell *matCellDef="let t">
<mat-icon *ngIf="t == expandedTransaction; else notExpanded" svgIcon="chevron-down"></mat-icon>

Check warning on line 43 in src/app/account-app/account-transactions.component.html

GitHub Actions / Run lint tests

Expected `===` but received `==`
<ng-template #notExpanded>
<mat-icon svgIcon="chevron-right"></mat-icon>
</ng-template>
</ng-container>
<ng-container matColumnDef="expandedDetails">
<td mat-cell *matCellDef="let t" [attr.colspan]="displayedColumns.length">
<div class="expandedDetails" [@detailExpand]="t == expandedTransaction ? 'expanded' : 'collapsed'">

Check warning on line 59 in src/app/account-app/account-transactions.component.html

GitHub Actions / Run lint tests

Expected `===` but received `==`
<!-- yo dawg, I heard you like tables -->
<table class="detailsTable">
<tr>
`],
template: `
<ng-container><span #ref><ng-content select="[custom_template]"></ng-content></span></ng-container>
<ng-container *ngIf="ref.childNodes.length == 0">

Check warning on line 37 in src/app/account-app/runbox-timer.ts

GitHub Actions / Run lint tests

Expected `===` but received `==`
<span class="timeunit years" *ngIf="runningDuration.years() > 0">{{runningDuration.years()}} years,</span>
<span class="timeunit months" *ngIf="runningDuration.months() > 0"> {{runningDuration.months()}} months,</span>
<span class="timeunit days" *ngIf="runningDuration.days() > 0"> {{runningDuration.days()}} days,</span>
constructor(public app: RMM) {}
async ngOnInit() {

Check warning on line 46 in src/app/account-details/account-settings.component.ts

GitHub Actions / Run lint tests

Lifecycle interface 'OnInit' should be implemented for method 'ngOnInit'. (https://angular.io/styleguide#style-09-01)
this.app.account_settings.load().subscribe((settings) => {
Object.keys(settings.result).forEach((key) =>
this.settingsArray.push({
this.loadTimezones();
}
ngOnInit() {

Check warning on line 71 in src/app/account-details/personal-details.component.ts

GitHub Actions / Run lint tests

Lifecycle interface 'OnInit' should be implemented for method 'ngOnInit'. (https://angular.io/styleguide#style-09-01)
if (!this.rmm.account_security.user_password) {
this.show_modal_password();
}
constructor(public app: RMM) {
}
ngOnInit() {

Check warning on line 44 in src/app/account-details/storage-data.component.ts

GitHub Actions / Run lint tests

Lifecycle interface 'OnInit' should be implemented for method 'ngOnInit'. (https://angular.io/styleguide#style-09-01)
this.app.account_storage.getUsage().subscribe(dataUsage => {
const usageArray = [];
Object.keys(dataUsage.result).forEach(key => usageArray.push(
this.rmm.me.load();
}
ngOnInit() {

Check warning on line 41 in src/app/account-security/sessions.component.ts

GitHub Actions / Run lint tests

Lifecycle interface 'OnInit' should be implemented for method 'ngOnInit'. (https://angular.io/styleguide#style-09-01)
this.rmm.account_security.session.list();
}
}
<mat-list-item *ngFor="let fce of folderListEntries" (click)="moveMessages(fce.folderId)"
[style.paddingLeft.px]="fce.folderLevel*10"
>
<mat-icon *ngIf="fce.folderType=='inbox'" mat-list-icon class="folderIconStandard" svgIcon="inbox-arrow-down"></mat-icon>

Check warning on line 33 in src/app/actions/movemessage.action.ts

GitHub Actions / Run lint tests

Expected `===` but received `==`
<mat-icon *ngIf="fce.folderType=='sent'" mat-list-icon class="folderIconStandard" svgIcon="send"></mat-icon>
<mat-icon *ngIf="fce.folderType=='spam'" mat-list-icon class="folderIconStandard" svgIcon="cancel"></mat-icon>
<mat-icon *ngIf="fce.folderType=='templates'" mat-list-icon class="folderIconStandard" svgIcon="file-document"></mat-icon>