feat(a11y-table): Define a standalone table component #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowbas
force-pushed
the
shadowbas/feat-accessible-table
branch
from
596aec9 to
972eb6a
Compare
shadowbas
commented
Dec 5, 2024
| canvastablecontainer { | ||
| opacity: 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
Would be better to instead get rid of anything canvas related in the code.
shadowbas
commented
Dec 5, 2024
src/app/app.component.scss
Outdated
| @@ -68,3 +72,10 @@ | |||
| width: 150px; | |||
| } | |||
|
|
|||
| .text-primary { | |||
| color: #01579b; | |||
There was a problem hiding this comment.
Move to a css property
shadowbas
commented
Dec 5, 2024
| return Array.from(this.selectedRows).map(x => x.id); | ||
| } | ||
|
|
||
| updateRows() { |
There was a problem hiding this comment.
This is where I normalize the sync messages and non-sync messages. It's a mess but the simplest I could thing of
shadowbas
commented
Dec 5, 2024
src/app/app.component.ts
Outdated
| this.rows = (() => { | ||
| if (!this.canvastable?.rows?.rows?.length) return [] | ||
|
|
||
| if (Array.isArray(this.canvastable.rows.rows[0])) |
There was a problem hiding this comment.
This is for when the rows are the arrays where the first item is the messageid.
gtandersen
approved these changes
Dec 5, 2024
|
Initial thoughts
|
shadowbas
commented
Jan 6, 2025
| async enrichRows() { | ||
| const { start, end } = this.renderedRange | ||
|
|
||
| this.rows = await Promise.all(mapOverIndexes(async (value) => { |
There was a problem hiding this comment.
This might cause a race condition. When renderedRange changes twice; it might happen that the first range change resolves later than the second range change.
- Find a way to merge resolved arrays in a way that will keep the latest and not overwrite fetched rows
Add table to the app component.
This removes the error where it complains about a property change after render.
- Setup a sane default for column widths. - Convert absolute columns widths to relative ones. https://codepen.io/Neizan/pen/ExajoJe
shadowbas
force-pushed
the
shadowbas/feat-accessible-table
branch
from
7c02014 to
62b6d40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add table to the app component.
Use j and k to scroll up and down in messages.Dropped the support for j and k scroll.