Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing ANSIBLE_BINARIES_DIR_PATH resolution #342

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Fixing ANSIBLE_BINARIES_DIR_PATH resolution #342

merged 8 commits into from
Nov 9, 2023

Conversation

Simon-cto
Copy link
Contributor

Changed to the PropertyResolver.resolveProperty method to get the correct resolution (jobconf first, then projectconf).

#331

@fdevans fdevans requested a review from ltamaster September 28, 2023 16:06
@fdevans fdevans added this to the 4.18.0 milestone Sep 28, 2023
@ltamaster ltamaster modified the milestones: 4.18.0, 4.17.2 Oct 18, 2023
@fdevans fdevans modified the milestones: 4.17.2, 5.0.0 Nov 3, 2023
Simon-cto
Simon-cto commented Nov 8, 2023
View reviewed changes
Copy link
Contributor Author

@Simon-cto Simon-cto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding requested code to replace data references

@ltamaster ltamaster merged commit 85cf709 into rundeck-plugins:main Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltamaster ltamaster ltamaster approved these changes

Assignees
No one assigned
Labels
to-jira
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Simon-cto @ltamaster @fdevans