Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ansible_ssh_pass rather than ansible_ssh_password + increase default limits on yaml + Fix null pointer issue(s) #388

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

madsi1m
Copy link

@madsi1m madsi1m commented Aug 23, 2024

Use ansible_ssh_pass rather than ansible_ssh_password to align with ansible.
Seems some of the code has already been changed.

@madsi1m madsi1m changed the title use ansible_ssh_pass rather than ansible_ssh_password use ansible_ssh_pass rather than ansible_ssh_password + Fix null pointer issue(s) Oct 9, 2024
@madsi1m madsi1m changed the title use ansible_ssh_pass rather than ansible_ssh_password + Fix null pointer issue(s) use ansible_ssh_pass rather than ansible_ssh_password + increase default limits on yaml + Fix null pointer issue(s) Oct 9, 2024
@tpegeot
Copy link

tpegeot commented Oct 9, 2024

Hello,
I tried your fix for the null pointer but I couldn't compile the code as the call to the "continue" statement is done outside of a loop. Are you sure that it is the right version ?
Thomas

@madsi1m
Copy link
Author

madsi1m commented Oct 9, 2024

@tpegeot Thanks, you are correct, i did a bad copy paste.
Please try again.

@madsi1m
Copy link
Author

madsi1m commented Oct 11, 2024

I've also had to rewrite it to make the scan recursive...

@alexander-variacode
Copy link
Contributor

@madsi1m do you have an inventory to share?. It's to replicate the case.

@madsi1m
Copy link
Author

madsi1m commented Oct 23, 2024

I can't share our inventory but basically it seems something like:

[prod1web]
web1.server.com
web2.server.com
web3.server.com

[prod1db]
db1.server.com
db2.server.com
db3.server.com

[product1:children]
prod1web
prod1db

[site1:children]
product1

[web:children]
prod1web

[db:children]
prod1db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants