Fix ssh-copy.sh for invalid indirect expansion

[thlc]

As seen in bug #21, here is the same fix for ssh-copy.sh.
Would close bug #31.

[Kuermel]

Unfortunately, we are also affected by the same problem.
With the patch we could use our secured SSH config.
Is there a schedule when this will be added in a new version?

[hmn]

The patch works for me, it would be nice with a new release with it

I tested on an Ubuntu 22.04

[Kuermel]

With every update the plugin is overwritten again.
It would be nice if someone could merge this little fix.

[daniel-chamberland]

@thlc Line 120 should contain rd_secure_password, not rd_secure_passphrase.
@Kuermel It doesn't prevent the issue, but I've automated an update of the plugin in my environment to quickly fix this. See my comment here: #21 (comment)

[thlc]

@thlc Line 120 should contain rd_secure_password, not rd_secure_passphrase.

Thanks, good catch, I fixed it.

[Kuermel]

We replaced the "openssh-node-execution-2.0.2.zip" with the modified openssh-node-execution-2.0.3.zip in the folder "/var/lib/rundeck/libext". This survives a reboot, but not a Rundeck update.
openssh-node-execution-2.0.3.zip

[daniel-chamberland]

matches changes made to ssh-exec.sh

[daniel-chamberland]

As a layman, I saw I could approve the PR. Was worth a shot.

[mleo2003]

I also submitted a PR for this same thing. I'm happy to see any fix applied at this point.

[Kuermel]

As the patch has still not been included in the latest update, here is an updated ZIP with the patch and an increased version number. This will prevent the patch from being reverted when updating/restarting Rundeck.

Simply replace the openssh-node-execution-2.0.3.zip in the folder “/var/lib/rundeck/libext” with the openssh-node-execution-2.0.4.zip. This should last until the next update of the plugin.

openssh-node-execution-2.0.4.zip

[doniz]

Any ETA when this will be released?

[xeon1400]

Problem is still present... when will 2.0.4 included in the normal rundeck release?

[thlc]

Wow, I was so young when I wrote this pull request!

Kidding aside, it seems the problem might have been fixed through another more recent pull request -> #35

[robmolenaar]

No not completely, the one on line 93 (for using a passphrase) is still there and still gives the same warning.