replace .success() with .done() due to JS deprecation. Fixes UI dash load error. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akh13
changed the title
|
thanks ! it works on 4.11 |
|
Thank you. This now works in 4.9, 4.10 and 4.11 :) |
|
Are there plans to merge this PR? Is the plugin even supported at this point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the duplicate PR. This seems to fix a dashboard load error that prevents the javascript from running properly. Without it, I receive this in the console:
Uncaught TypeError: loader.load(...).success is not a function
loadNextJob https://rundeck.testsite.com/plugin/file/UI/ui-job-graph/js/jobgraph.js:755
loadJobListData https://rundeck.testsite.com/plugin/file/UI/ui-job-graph/js/jobgraph.js:763
loadJobsListPage https://rundeck.testsite.com/plugin/file/UI/ui-job-graph/js/jobgraph.js:459
To fix this, the method has to be changed as below, because there is .success() in these locations. Can someone please verify if this fix works?