Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create lfghelper #7412

Merged
merged 7 commits into from
Feb 24, 2025
Merged

Create lfghelper #7412

merged 7 commits into from
Feb 24, 2025

Conversation

Lorkrakt
Copy link
Contributor

The LFG Helper plugin helps RuneScape players quickly find groups for PVM content by providing a simple, user-friendly interface in the RuneLite sidebar. Players can specify group details like boss name, team size, clanchat, and world, and submit these details to a designated Discord channel via a webhook.

Features:
Simple Form Interface: Enter boss name, team size, clanchat, and more.
Discord Integration: Sends LFG request to a Discord channel with a custom webhook.
Role Support: Sends a message tagging the specified "PVMer" role on Discord.
Automatic Data Population: Includes the player’s in-game name in the request.

This plugin streamlines the process of looking for PVM groups, making it easier for players to coordinate and find groups within their communities

@runelite-github-app
Copy link

runelite-github-app bot commented Feb 13, 2025

commas are the bane of my existence.
@Lorkrakt
Copy link
Contributor Author

This is ready for review whenever someone's ready.

cleaned up licensing on files. dont need on individual files. was redundant.
@LlemonDuck
Copy link
Contributor

Required:

  • Use an injected OkHttpClient to asynchronously send the discord payload instead of performing the i/o on swing thread

Recommended:

  • Use ImageUtil#loadImageResource and ImageUtil#resizeImage to simplify your nav button image loading, optionally just not resizing at all since the icon is already 16x16
  • Use injector.getInstance(lfghelperpanel.class); instead of manually instantiating the panel, which allows you to @Inject fields into it
  • Use gson to build your discord payload which will prevent text-escaping issues

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 16, 2025
made changes based on RL maintainer requirements/recommendations
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Feb 16, 2025
fixing gson creation
@Lorkrakt
Copy link
Contributor Author

Ready for review again.
Changes made:

Switched to OkHttpClient per RL Maintainer requirement
Made adaptions based on recommend

Fixed gson creation per workflow failure.

@LlemonDuck
Copy link
Contributor

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 24, 2025
update per RL maintainer
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Feb 24, 2025
@Lorkrakt
Copy link
Contributor Author

Change made!
Ready to go again.

@LlemonDuck LlemonDuck merged commit e6cd022 into runelite:master Feb 24, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants