Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nekos #7491

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update nekos #7491

wants to merge 4 commits into from
+1 −1

Conversation

Ondra-D
Copy link
Contributor

@Ondra-D Ondra-D commented Feb 20, 2025 •
edited
Loading

  • Improved overlay rendering for better performance.
  • Added the option to change the image type displayed (Nekos, Kitsune and cats (for the normies))

@runelite-github-app
Copy link

runelite-github-app bot commented Feb 20, 2025 •
edited
Loading

nekos: 39369dec839c2f06eadda09e7fe1429e6caaad8d...66182e260ebeacd16e643dee502896925e9a7e98

@LlemonDuck
Copy link
Contributor

You should use an injected OkHttpClient for http requests

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 24, 2025
@Ondra-D
Update nekos
6aebd27 
- Made http requests through Okhttp
- Added max and min ranges for opacity and delay
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Feb 24, 2025
@LlemonDuck
Copy link
Contributor

What's the goal with this VolatileImage? You shouldn't need it

@Ondra-D
Copy link
Contributor Author

Ondra-D commented Feb 25, 2025

If I try to render just the buffered image the game freezes for a second, does not happen with the volatile one.

@LlemonDuck
Copy link
Contributor

Instead of using a VolatileImage, try something like setting a "loaded" flag after the image has finished loading, and don't attempt to draw the image until that is set. You're probably just hanging the render thread waiting on the image to load.

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 25, 2025
@iProdigy
Copy link
Member

also avoid locking in Overlay#render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin change waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ondra-D @LlemonDuck @iProdigy