AssignCodewords fix double overflow of marker[1] #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you do not have the break where I put it, `marker[1]` would get executed twice. So from `marker[1] == 1`, it would first become `marker[1] == 2` (10_b) and then `marker[1] == 3` (11_b), which is probably not intended. This might not matter, as it only happens once the leaf is overful, i.e. fully specified, but it would allow for a simpler underspecify check at the end (which currently is missing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you do not have the break where I put it,
marker[1]would get executed twice. So frommarker[1] == 1, it would first becomemarker[1] == 2(10_b) and thenmarker[1] == 3(11_b), which is probably not intended. This might not matter, as it only happens once the leaf is overful, i.e. fully specified, but it would allow for a simpler underspecify check at the end (which currently is missing).