use List instead of WordStack for wordStack cell #2364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwightguth
force-pushed
the
wordstack
branch
8 times, most recently
from
05068f2 to
6ee5133
Compare
dwightguth
force-pushed
the
wordstack
branch
2 times, most recently
from
f1f2ed0 to
67b3c78
Compare
dwightguth
force-pushed
the
wordstack
branch
2 times, most recently
from
d03895a to
9f5e1e4
Compare
added 11 commits
April 5, 2024 11:54
dwightguth
pushed a commit
to Pi-Squared-Inc/evm-semantics
that referenced
this pull request
Apr 16, 2024
dwightguth
pushed a commit
to Pi-Squared-Inc/evm-semantics
that referenced
this pull request
Jun 17, 2024
dwightguth
pushed a commit
to Pi-Squared-Inc/evm-semantics
that referenced
this pull request
Jun 18, 2024
dwightguth
pushed a commit
that referenced
this pull request
Jun 18, 2024
dwightguth
pushed a commit
that referenced
this pull request
Jun 25, 2024
Robertorosmaninho
pushed a commit
to Pi-Squared-Inc/evm-semantics
that referenced
this pull request
Jul 5, 2024
Robertorosmaninho
pushed a commit
to Pi-Squared-Inc/evm-semantics
that referenced
this pull request
Jul 9, 2024
Robertorosmaninho
pushed a commit
to Pi-Squared-Inc/evm-semantics
that referenced
this pull request
Jul 9, 2024
dwightguth
pushed a commit
to Pi-Squared-Inc/evm-semantics
that referenced
this pull request
Jul 9, 2024
Robertorosmaninho
pushed a commit
to Pi-Squared-Inc/evm-semantics
that referenced
this pull request
Aug 7, 2024
Robertorosmaninho
pushed a commit
to Pi-Squared-Inc/evm-semantics
that referenced
this pull request
Aug 13, 2024
Robertorosmaninho
pushed a commit
to Pi-Squared-Inc/evm-semantics
that referenced
this pull request
Sep 12, 2024
dwightguth
pushed a commit
to Pi-Squared-Inc/evm-semantics
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sizeable amount of time is being spent computing the size of the word stack cell on every opcode. This is less than ideal because the wordStack cell is just a stack and therefore ought to have push, pop, and length operations in constant time. However, this is not really achievable with the
consimplementation of the stack.We replace the
WordStacksort as it is being used by thewordStackcell with theListsort. This improves performance somewhat, but a lot of time is still being spent pushing elements onto the list, because this operation, implemented naively, consists of constructing a new list with one element and appending them together.We therefore make use of the
pushListoperator defined in recent versions of the K prelude to get significantly superior performance for pushing elements onto the stack. With this change, stack operations like push, pop, and length, are observed to occupy almost no time within the time profile.